feat(canvas): refine Notes workflow by Owen-Richard · Pull Request #103 · github/replica

Owen-Richard · 2026-10-23T18:55:03Z

Before:

Many clicks for pick & polish: Click button, then have to click page (overlay goes away) and then move hover and then click
There are too many clicks for most interactions lets make this snappier
Strings labelling the feature are inconsistent, is it a note? an improvement? both?

What changes

This is a full Pick & polish Notes workflow update

Starting Pick & polish now begins target selection immediately while source capture continues in the background. Reviewers can press S to start or cancel selection from the canvas or preview, including while capture is pending.
The Notes counter opens and closes the sidebar independently from selection. Saved pins remain available without the sidebar, and guarded dismissal protects drafts and active conversations.
Notes use the selected target as the conversation heading
Reviewers can save with Command+Enter or Control+Enter. Compact keycaps show the shortcut without crowding the composer.
Ordinary Comments and Pick & polish remain available together. Only the active review surface controls its pins and selections, and unfinished work prevents the other surface from interrupting it.
Preview shortcut requests require the current authenticated connection, a focused preview, and a trusted user gesture so embedded content cannot forge selection changes.

Storybook screenshots

Components/Prototype canvas/Improvement threads: Pins Without Sidebar (light; 1440x900)

Components/Prototype canvas/Improvement threads: Active Notes (light; 1440x900)

Components/Prototype canvas/Improvement threads: Blocked Notes (light; 1440x900)

Components/Prototype canvas/Improvement threads: Copilot Answer (light; 1440x900)

Components/Prototype canvas/Improvement threads: Author Identity Unavailable (light; 1440x900)

Components/Prototype canvas/Improvement threads: No Pending Requests (light; 1440x900)

Components/Prototype canvas/Follow-up thread sample: Sample (light; 1440x900)

Start selection immediately, retain captured note provenance, and ignore cancelled capture results. Cover delayed capture and direct hover-to-pick behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Support V in the canvas and preview, preserve Escape cancellation, and leave typing and dialogs alone. Document the shortcut and cover authenticated forwarding and packaged browser behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Replace the V shortcut with S across the canvas, preview bridge, accessible metadata, copy, documentation, tests, and built assets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Keep S shortcut cancellation from moving focus to the Pick & polish toolbar button while retaining existing focus restoration for direct controls and Escape flows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Copilot

🟡 Changes recommended

Confirmed interaction and keyboard-handling regressions can hide draft controls, interrupt prototype input, and prevent cancellation.

7 open issues

2 files not reviewed

.github/extensions/replica-prototype/assets/renderer-improvement-notes-prototype.js: Generated file
.github/extensions/replica-prototype/assets/renderer-prototype-canvas-improvement-threads.js: Generated file

What changed in this PR

Refines the prototype canvas’s Pick & polish Notes workflow, making selection faster and conversation controls more consistent.

Changes:

Adds S-key selection toggling and immediate selection during source capture.
Updates conversation dismissal, filtering, deletion, labels, and the Notes counter.
Adds Save shortcuts and keycaps, expands interaction coverage, and refreshes extension assets and documentation.

File	Description
`hub/vite.prototype-canvas.config.mjs`	Includes the shortcut helper in the Notes bundle.
`hub/script/check-prototype-canvas-renderer.mjs`	Expands renderer interaction checks.
`hub/docs/prototype-canvas.md`	Documents the updated Notes workflow.
`hub/app/javascript/utils/is-annotation-shortcut/index.ts`	Adds shared S-key shortcut detection.
`hub/app/javascript/features/prototype-canvas-improvement-threads/styles.css`	Styles header actions and direct deletion.
`hub/app/javascript/features/prototype-canvas-improvement-threads/index.tsx`	Updates conversation dismissal and row actions.
`hub/app/javascript/features/prototype-canvas-improvement-threads/index.test.tsx`	Covers dismissal, draft protection, and deletion.
`hub/app/javascript/features/prototype-canvas-improvement-threads/en.ts`	Revises Notes, filter, and deletion labels.
`hub/app/javascript/features/prototype-canvas-improvement-notes/use-preview-selection/index.ts`	Handles preview toggles and dismissal metadata.
`hub/app/javascript/features/prototype-canvas-improvement-notes/styles.css`	Adds Save keycaps and adjusts pin focus styling.
`hub/app/javascript/features/prototype-canvas-improvement-notes/index.tsx`	Adds immediate selection, counter toggling, and submission shortcuts.
`hub/app/javascript/features/prototype-canvas-improvement-notes/en.ts`	Updates selection hints and composer labels.
`hub/app/javascript/application/prototype-preview-bridge/index.ts`	Forwards shortcuts and preview pointer dismissal.
`hub/app/javascript/application/prototype-preview-bridge/improvement-selection.test.ts`	Tests shortcut authentication and dismissal behavior.
`hub/app/javascript/application/prototype-canvas/tests/improvement-notes.test.tsx`	Expands capture, cancellation, submission, and focus coverage.
`.github/extensions/replica-prototype/assets/renderer-prototype-canvas-improvement-threads.js`	Refreshes bundled conversation presentation.
`.github/extensions/replica-prototype/assets/renderer-improvement-notes-prototype.js`	Refreshes bundled Notes orchestration and shortcuts.

_{Review effort: Max}

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

nshki

Thanks for the polish here, @Owen-Richard! Left a couple change requests. Also if you don't mind, could you ask your agent to update the PR title and description according to our conventions?

Happy to chat about this in the channel if needed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca # Conflicts: # .github/extensions/replica-prototype/assets/canvas-bridge.js # .github/extensions/replica-prototype/assets/renderer.css # .github/extensions/replica-prototype/assets/renderer.js

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

## Why  Bundler Audit can block a pull request when a security fix is available but still too new for the seven-day dependency policy. This conflict is blocking #103. ## What changes    Removes the Bundler Audit job from Hub's GitHub Actions workflow and updates the dependency-policy guide. Dependabot remains responsible for dependency vulnerability alerts. The seven-day dependency checks, lockfiles, local Bundler Audit command, and local `bin/ci` audit step stay unchanged. The branch rules for `main` still require `Bundler audit`. An administrator must remove that required check when merging this change so GitHub does not wait for a job that no longer exists. This PR does not change repository rules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Nishiki Liu <hello@nshki.com>

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca # Conflicts: # .github/extensions/replica-prototype/assets/canvas-bridge.js # .github/extensions/replica-prototype/assets/renderer-improvement-notes-prototype.js # .github/extensions/replica-prototype/assets/renderer-prototype-canvas-improvement-threads.js # .github/extensions/replica-prototype/assets/renderer.css # .github/extensions/replica-prototype/assets/renderer.js # hub/app/javascript/features/prototype-canvas-improvement-notes/index.tsx # hub/app/javascript/features/prototype-canvas-improvement-notes/use-preview-selection/index.ts # hub/docs/prototype-canvas.md

Owen-Richard added 20 commits October 23, 2026 11:41

fix(canvas): dismiss improvement conversations outside

5cb8fab

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): improve delete action contrast

ab2adb4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

feat(canvas): submit improvement notes by shortcut

6d52b58

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

refactor(canvas): title notes by target

51ee10c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

refactor(canvas): simplify single note actions

91a5d3c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): call improvements notes in deletion

7705d77

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): simplify notes sidebar copy

94d60f9

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): align Notes sidebar label

ef63731

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): rename note picker tooltip

85aa18f

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): toggle Notes from count

68dca4d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

style(canvas): format note integration test

acf5afd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): return note dismiss to header

87346e5

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): add Retry action icon

e159c95

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): keep one note pin focus ring

e7e77b4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

style(canvas): polish Save shortcut keycaps

b084264

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

style(canvas): format note UI checks

5535971

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Owen-Richard requested review from a team and nshki as code owners October 23, 2026 18:55

Copilot AI max review requested due to automatic review settings October 23, 2026 18:55

Copilot started reviewing on behalf of Owen-Richard October 23, 2026 18:55

View session

Owen-Richard added 4 commits October 23, 2026 12:08

fix(canvas): name Notes toggle actions

b62ecc2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): align note accessibility labels

8a31009

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): simplify note composer copy

4f51aab

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

chore(deps): update crass

b7bed2d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Copilot AI reviewed Oct 23, 2026

View reviewed changes

test(canvas): stabilize renderer route teardown

1006549

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Owen-Richard added 8 commits October 23, 2026 12:32

style(canvas): center Save shortcut keycaps

6b42230

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): harden annotation shortcut events

ee9e649

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): scope prototype pointer dismissal

a4d6a28

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): guard Notes counter close

0608ed2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): cancel pending target with S

a33f139

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): cancel pending target on Escape

e547089

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): preserve Notes sidebar controls

6526e5d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): validate preview dismissal payload

075dff3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

nshki requested changes Oct 23, 2026

View reviewed changes

Comment thread .github/workflows/dependency-age.yml Outdated

Comment thread hub/app/javascript/application/prototype-canvas/tests/improvement-notes.test.tsx

Owen-Richard changed the title ~~Improve prototype canvas Notes workflow~~ feat(canvas): refine Notes workflow Oct 23, 2026

Owen-Richard added 3 commits October 23, 2026 13:47

fix(deps): keep dependency age strict

21fdf9d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

test(canvas): focus Notes regression coverage

06a7638

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Owen-Richard requested a review from nshki October 23, 2026 20:59

Owen-Richard self-assigned this Oct 23, 2026

chore(deps): defer crass upgrade

1a05726

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

github-advanced-security AI found potential problems Oct 23, 2026

View reviewed changes

Comment thread hub/app/javascript/utils/is-annotation-shortcut/index.ts

Copilot AI mentioned this pull request Oct 23, 2026

ci(hub): remove Bundler Audit check #109

Merged

Owen-Richard and others added 2 commits October 23, 2026 16:02

Merge remote-tracking branch 'origin/main' into owen/10-22-canvas-polish

b45feca

Potential fix for pull request finding

95fc11d

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

github-advanced-security AI found potential problems Oct 23, 2026

View reviewed changes

Comment thread hub/app/javascript/features/prototype-canvas-improvement-notes/use-preview-selection/index.ts

Owen-Richard added 3 commits October 23, 2026 16:12

test(canvas): cover trusted shortcut events

4de7113

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

build(extension): refresh shortcut assets

207a583

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

fix(canvas): require gesture for preview toggle

64a6515

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2eb9311-df5e-4a24-9722-b52c1e2eaeca

Owen-Richard enabled auto-merge (squash) October 23, 2026 23:38

nshki approved these changes Oct 26, 2026

View reviewed changes

Owen-Richard merged commit 1d097bf into main Oct 26, 2026
39 checks passed

Owen-Richard deleted the owen/10-22-canvas-polish branch October 26, 2026 17:03

Navigation Menu

Repository navigation

feat(canvas): refine Notes workflow - #103

feat(canvas): refine Notes workflow#103
Owen-Richard merged 44 commits into
mainfrom
owen/10-22-canvas-polish

Owen-Richard commented Oct 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nshki left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Owen-Richard commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes

Storybook screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nshki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Owen-Richard commented Oct 23, 2026 •

edited

Loading